docs(timestamps): fix outdated enabling timestamping section - #787
Open
Chennamma-Hotkar wants to merge 1 commit into
Open
Chennamma-Hotkar wants to merge 1 commit into
Chennamma-Hotkar wants to merge 1 commit into
Conversation
Replace old shim/env-var instructions with config.toml approach. Update log path from /tmp/urunc.zlog to /var/log/urunc/timestamps.log. Closes urunc-dev#624 Signed-off-by: Chennamma-Hotkar <channuhotkar@gmail.com>
✅ Deploy Preview for urunc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 15 days. |
cmainas
reviewed
Sep 2, 2026
cmainas
left a comment
cmainas
left a comment
Contributor
There was a problem hiding this comment.
Hello @Chennamma-Hotkar ,
thank you for the PR, I have add ed some small comments.
| ``` | ||
|
|
||
| The timestamp logs are located at `/tmp/urunc.zlog`: | ||
| The timestamp logs are located at `/var/log/urunc/timestamps.log`: |
Contributor
There was a problem hiding this comment.
Change the text here and point to the location defined by the configuration.
| ``` | ||
|
|
||
| To add the "timestamping" urunc to containerd config: | ||
| No separate `containerd-shim` or container runtime configuration is required — urunc reads this setting directly at startup. |
Contributor
There was a problem hiding this comment.
Having a separate contianerd entry for urunc and timestamps useful. Please take look at https://urunc.io/configuration/#configuration-file-location to see how this can be enabled (two different urunc shims; one for timestamp)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The "How to enable timestamping" section in
docs/developer-guide/timestamps.mddescribed an outdated method (creating a separate containerd-shim wrapper +URUNC_TIMESTAMPS=1env var). urunc has since moved to a config.toml-based approach (confirmed via #596).This PR updates the docs to:
io.containerd.uruncts.v2toio.containerd.urunc.v2/tmp/urunc.zlogto/var/log/urunc/timestamps.logRelated issues
How was this tested?
Verified no other files reference the outdated method:
Manually reviewed the full rendered file for correct markdown formatting and accuracy against the current
urunc_config.godefaults and PR #596.LLM usage
N/A
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).